Skip to content

Conversation

@MichalStrehovsky
Copy link
Member

I missed the extra Activator in Activator.RuntimeType.cs (the rest are in Activator.cs). This was flagged on the NativeAOT side.

Also missed the APIs on ModuleHandle that I found by accident just now.

I missed the extra `Activator` in Activator.RuntimeType.cs (the rest are in Activator.cs). This was flagged on the NativeAOT side.

Also missed the APIs on `ModuleHandle` that I found by accident just now.
@ghost
Copy link

ghost commented May 21, 2021

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented May 21, 2021

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@eerhardt
Copy link
Member

    public static ObjectHandle? CreateInstance(string assemblyName, string typeName)

I don't think these CreateInstance(string, string) overloads are public in the ref file, but would it be possible to annotate them as well while we are in here?


Refers to: src/libraries/System.Private.CoreLib/src/System/Activator.RuntimeType.cs:42 in d9ba474. [](commit_id = d9ba474, deletion_comment = False)

@eerhardt
Copy link
Member

    public static ObjectHandle? CreateInstance(string assemblyName, string typeName)

Oh, I was looking in the wrong spot - they are public:

        public static System.Runtime.Remoting.ObjectHandle? CreateInstance(string assemblyName, string typeName) { throw null; }
        public static System.Runtime.Remoting.ObjectHandle? CreateInstance(string assemblyName, string typeName, bool ignoreCase, System.Reflection.BindingFlags bindingAttr, System.Reflection.Binder? binder, object?[]? args, System.Globalization.CultureInfo? culture, object?[]? activationAttributes) { throw null; }
        public static System.Runtime.Remoting.ObjectHandle? CreateInstance(string assemblyName, string typeName, object?[]? activationAttributes) { throw null; }

In reply to: 845998773


Refers to: src/libraries/System.Private.CoreLib/src/System/Activator.RuntimeType.cs:42 in d9ba474. [](commit_id = d9ba474, deletion_comment = False)

@MichalStrehovsky
Copy link
Member Author

Oh, I was looking in the wrong spot - they are public:

Those are also illink intrinsics, so it's not a hole, but I fixed those and filed #53121 for the other cases. We should go over them.

Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for fixing this up.

@MichalStrehovsky MichalStrehovsky merged commit 42f6948 into dotnet:main May 24, 2021
@MichalStrehovsky MichalStrehovsky deleted the createinst branch May 24, 2021 09:29
@ghost ghost locked as resolved and limited conversation to collaborators Jun 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants